refactor: adjust sharing ng role names and descriptions #8743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjusts display names and descriptions of sharing NG roles to align with the previously agreed upon terms.
JammingBen
force-pushed
the
adjust-sharing-ng-role-names
branch
from
6d7cab3 to
2968570
Compare
JammingBen
force-pushed
the
adjust-sharing-ng-role-names
branch
from
b3bef14 to
66b29dc
Compare
|
SonarCloud complains about things that I either didn't touch or are nonsense IMO 🤷 |
fschade
reviewed
Mar 27, 2024
fschade
approved these changes
Mar 27, 2024
its ok, SC asks to use ResourcePermissions getters instead of directly accessing the properties, i took care, lets see |
Pardon my french, but SC is just being stupid here. Using Getters() for boolean 🤦♂️ |
|
ownclouders
pushed a commit
that referenced
this pull request
Mar 27, 2024
refactor: adjust sharing ng role names and descriptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adjusts display names and descriptions of sharing NG roles to align with the previously agreed upon terms.
Types of changes