-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autoprovsioning fixes #8952
Autoprovsioning fixes #8952
Conversation
@nicholas-wilson-au With this you should be able to set:
The "only" new thing is You'll likely also want to set:
To disable the graph service's internal username validation. When autoprovisioning is enabled we need to trust the username from the external IDP to be valid. |
98f3530
to
f763004
Compare
Will this be merged or is it stuck somewhere? |
Needs a code review |
Please add some description in readme.md |
…r auto-provisioning user accounts When auto-provisioning user accounts we used a fixed mapping for claims for the userinfo response to user attributes. This change introduces configuration options to defined which claims should be user for the username, display name and email address of the auto-provisioned accounts. This also removes the automatic fallback to use the 'mail' claim as the username when the 'preferred_username' claim does not exist. Fixes: owncloud#8635
The mail address is not a required attrbute for our users. So we can auto-provision users without it. Fixes: owncloud#6909
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, I am a bit unhappy about the behavior when one of the variables is misconfigured. I get an error in the logs telling me "claim 'xxx_xxxx' does not exist" but for the user it just redirects me to the "Login again" page. Some verbosity there would be nice (e.g. error message: "Login with the OIDC provider failed, please contact your administrator".
That is no new behavior. Happens also when you misconfigure the OIDC roles from claim config. Merging. |
@kulmann @JammingBen We should create a follow up for web. Given our user endpoint would return something more reasonable, (not 500 as of now), we should provide something for the end user like "contact your administrator". |
We introduce the new environment variables "PROXY_AUTO_PROVISION_CLAIM_USERNAME", "PROXY_AUTO_PROVISION_CLAIM_EMAIL", and "PROXY_AUTO_PROVISION_CLAIM_DISPLAYNAME" which can be used to configure the OIDC claims that should be used for auto-provisioning user accounts.
The automatic fallback to use the 'email' claim value as the username when the 'preferred_username' claim is not set, has been removed.
Also it is now possible to autoprovision users without an email address