Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] status code check in SpacesContext theUserCreatesASpaceWithQuotaUsingTheGraphApi #9341

Closed
phil-davis opened this issue Jun 10, 2024 · 1 comment
Assignees
Labels

Comments

@phil-davis
Copy link
Contributor

Describe the bug

The code does an exact equal === check:

		if ($response->getStatusCode() === '201') {
			$this->addCreatedSpace($user, $response);
		}

Investigate what is really happening, and what the consequences are for the test scenarios and scenario cleanup.
Make the appropriate fixes to the test code.

But getStatusCode() returns an int, so this check will never be true.

Expected behavior

addCreatedSpace happens when a new space is created by the tests.

Actual behavior

addCreatedSpace does not happen.

Setup

CI

@micbar micbar mentioned this issue Jun 19, 2024
24 tasks
@nirajacharya2
Copy link
Contributor

assigned to: @prashant-gurung899

@nirajacharya2 nirajacharya2 self-assigned this Jun 21, 2024
@phil-davis phil-davis changed the title [QA] status vode check in SpacesContext theUserCreatesASpaceWithQuotaUsingTheGraphApi [QA] status code check in SpacesContext theUserCreatesASpaceWithQuotaUsingTheGraphApi Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants