Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci][tests-only] fix status code check in theUserCreatesASpaceWithQuotaUsingTheGraphApi in SpacesContext #9430

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

prashant-gurung899
Copy link
Contributor

Description

This PR fixes the issue to check status code where getStatusCode() returns an int and addCreatedSpace() was not being called.

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this will help the test scenarios remember the created spaces, and clean up better at the end of each scenario.

@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/ocis/36110/47/5

runsh: Total unexpected failed scenarios throughout the test run:
coreApiWebdavMove2/moveFile.feature:141
coreApiWebdavMove2/moveFile.feature:142

I restarted CI to see if these fail again.

Signed-off-by: prashant-gurung899 <[email protected]>
@prashant-gurung899
Copy link
Contributor Author

https://drone.owncloud.com/owncloud/ocis/36110/47/5

runsh: Total unexpected failed scenarios throughout the test run:
coreApiWebdavMove2/moveFile.feature:141
coreApiWebdavMove2/moveFile.feature:142

I restarted CI to see if these fail again.

Okay Phil Ji!

Copy link

@phil-davis phil-davis merged commit a9ecd0c into owncloud:master Jun 21, 2024
4 checks passed
@prashant-gurung899 prashant-gurung899 deleted the check-status-code branch June 21, 2024 09:16
ownclouders pushed a commit that referenced this pull request Jun 21, 2024
[full-ci][tests-only] fix status code check in theUserCreatesASpaceWithQuotaUsingTheGraphApi in SpacesContext
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants