Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] upload artifacts of production, rolling or daily #9364

Merged
merged 8 commits into from
Jun 17, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented Jun 12, 2024

Description

This is a POC for deploying docker and binary build artifacts according to #9264.

What is known:

  • Production release docker tags: owncloud/ocis:x.x.x
  • Rolling release docker tags: owncloud/ocis-rolling:x.x.x (including production tags)
  • Production binary builds go to: stable subfolder
  • Rolling binary builds go to: rolling subfolder
  • Daily binary builds go to: daily subfolder

Q?:

  • What kind of builds go to testing subfolder? Pre-releases - alpha, beta, rc?
  • Docker tag for daily builds? owncloud/ocis-rolling:latest?
  • What should happen to previous docker tags and binary builds? (move to respective docker repo and binary subfolders?) - not related to this PR though

PR implementation: tag release type from #9264 (comment)

  • commit push:

    • docker-arm64-daily
    • docker-amd64-daily
    • manifest-daily
    • readme-daily
    • binaries-linux-daily
    • binaries-darwin-daily
  • v6.0.0-rc.1:

    • docker-arm64-rolling
    • docker-amd64-rolling
    • manifest-rolling
    • readme-rolling
    • binaries-linux-testing
    • binaries-darwin-testing
  • v6.0.0:

    • docker-arm64-rolling
    • docker-amd64-rolling
    • manifest-rolling
    • readme-rolling
    • binaries-linux-rolling
    • binaries-darwin-rolling
  • v7.0.0-rc.1:

    • docker-arm64-rolling
    • docker-amd64-rolling
    • manifest-rolling
    • readme-rolling
    • docker-arm64-production
    • docker-amd64-production
    • manifest-production
    • readme-production
    • binaries-linux-testing
    • binaries-darwin-testing
  • v7.0.0:

    • docker-arm64-rolling
    • docker-amd64-rolling
    • manifest-rolling
    • readme-rolling
    • docker-arm64-production
    • docker-amd64-production
    • manifest-production
    • readme-production
    • binaries-linux-rolling
    • binaries-darwin-rolling
    • binaries-linux-production
    • binaries-darwin-production

Related Issue

Motivation and Context

How Has This Been Tested?

  • ❗ END RESULT NOT TESTED

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link

update-docs bot commented Jun 12, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@micbar
Copy link
Contributor

micbar commented Jun 12, 2024

Good approach!

Please keep in mind, that all production tags are also rolling tags.

@saw-jan saw-jan force-pushed the ci/production-and-rolling-releases branch from e305fb1 to 2a71e8c Compare June 13, 2024 05:56
@saw-jan
Copy link
Member Author

saw-jan commented Jun 13, 2024

Please keep in mind, that all production tags are also rolling tags.

@micbar I have some questions regarding it in the PR description.
#9364 (comment)

Also, I have added about which pipelines will run on which type of events.

.drone.star Outdated Show resolved Hide resolved
.drone.star Show resolved Hide resolved
@saw-jan saw-jan requested a review from micbar June 13, 2024 06:53
@saw-jan saw-jan self-assigned this Jun 13, 2024
@saw-jan saw-jan force-pushed the ci/production-and-rolling-releases branch from 4e37d7e to cfb1999 Compare June 13, 2024 08:47
@saw-jan
Copy link
Member Author

saw-jan commented Jun 13, 2024

The PR is complete from my side and the things remaining is to test if it does the required job. I don't know how to confirm it. But I tested pipelines generation using:

drone starlark --max-execution-steps 100000000 --build.event="tag" --build.ref="refs/tags/v6.0.0" --repo.slug="owncloud/ocis" --repo.name="ocis"

drone starlark --max-execution-steps 100000000 --build.event="tag" --build.ref="refs/tags/v5.0.5" --repo.slug="owncloud/ocis" --repo.name="ocis"

drone starlark --max-execution-steps 100000000 --build.event="pull_request" --build.ref="refs/pull/123" --repo.slug="owncloud/ocis" --repo.name="ocis"

@micbar micbar force-pushed the ci/production-and-rolling-releases branch from cfb1999 to 7e5f278 Compare June 13, 2024 13:07
@micbar
Copy link
Contributor

micbar commented Jun 13, 2024

Rebased it.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@micbar
Copy link
Contributor

micbar commented Jun 13, 2024

Tested with a rolling tag, prerelease

1718285881208

@micbar micbar marked this pull request as ready for review June 13, 2024 14:40
@micbar micbar requested review from phil-davis and rhafer and removed request for phil-davis June 13, 2024 14:40
@saw-jan saw-jan changed the title [do-not-merge][ci] upload artifacts of production, rolling or daily [ci] upload artifacts of production, rolling or daily Jun 13, 2024
@micbar micbar merged commit 8dbc162 into master Jun 17, 2024
5 checks passed
ownclouders pushed a commit that referenced this pull request Jun 17, 2024
…ases

[ci] upload artifacts of production, rolling or daily
@saw-jan saw-jan deleted the ci/production-and-rolling-releases branch June 17, 2024 11:35
@micbar micbar mentioned this pull request Jun 18, 2024
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants