Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: bump reva and remove explicit automount mountpoint naming #9377

Merged
merged 2 commits into from
Jun 19, 2024
Merged

enhancement: bump reva and remove explicit automount mountpoint naming #9377

merged 2 commits into from
Jun 19, 2024

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Jun 13, 2024

Description

bumps reva, as a side-effect it removes the explicit automount mountpoint naming

Related Issue

How Has This Been Tested?

  • ci tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

@fschade fschade force-pushed the bump-reva-7fb5f11a24cf branch 2 times, most recently from f807c47 to 89b4aa1 Compare June 13, 2024 13:31
@aduffeck aduffeck mentioned this pull request Jun 17, 2024
Closed
@fschade fschade force-pushed the bump-reva-7fb5f11a24cf branch 3 times, most recently from b989156 to 8091437 Compare June 18, 2024 16:31
@fschade fschade marked this pull request as draft June 18, 2024 16:33
@fschade fschade force-pushed the bump-reva-7fb5f11a24cf branch from 8091437 to 9b53cd0 Compare June 19, 2024 10:54
@fschade fschade marked this pull request as ready for review June 19, 2024 11:03
@fschade fschade force-pushed the bump-reva-7fb5f11a24cf branch from 9b53cd0 to 4d477a9 Compare June 19, 2024 11:39
@fschade
Copy link
Contributor Author

fschade commented Jun 19, 2024

@rhafer && @micbar please check if the error check solution is ok four you, THX.

@fschade fschade force-pushed the bump-reva-7fb5f11a24cf branch from 4d477a9 to c508439 Compare June 19, 2024 12:20
@fschade fschade force-pushed the bump-reva-7fb5f11a24cf branch from c508439 to 3280b22 Compare June 19, 2024 13:57
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
73.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ScharfViktor ScharfViktor mentioned this pull request Jun 19, 2024
Closed
24 tasks
micbar
micbar approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok-ish for me now. Better than the using string comparisons.

We need a error handling improvement for the full stack soon.

@2403905 2403905 merged commit d95545a into owncloud:master Jun 19, 2024
3 checks passed
ownclouders pushed a commit that referenced this pull request Jun 19, 2024
@2403905
Merge pull request #9377 from fschade/bump-reva-7fb5f11a24cf
11ef16f 
enhancement: bump reva and remove explicit automount mountpoint naming
@fschade
Copy link
Contributor Author

fschade commented Jun 19, 2024

This is ok-ish for me now. Better than the using string comparisons.

We need a error handling improvement for the full stack soon.

I couldn’t agree more!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kobergj kobergj kobergj approved these changes

@2403905 2403905 2403905 approved these changes

@micbar micbar micbar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fschade @micbar @2403905 @kobergj