Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to disable versioning #9473

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Allow to disable versioning #9473

merged 2 commits into from
Jun 27, 2024

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Jun 26, 2024

Adds an option to disable versioning for the storage providers.

Fixes #9282

@kobergj kobergj force-pushed the AllowDisableVersioning branch from dc4ee0b to 1c10505 Compare June 26, 2024 11:02
@mmattel
Copy link
Contributor

mmattel commented Jun 26, 2024

I need to ask here (not in the suggestions where it gets lost), why not adding or only using a global envvar?

@kobergj kobergj force-pushed the AllowDisableVersioning branch from cd2ef42 to 4980ceb Compare June 26, 2024 11:21
@kobergj
Copy link
Collaborator Author

kobergj commented Jun 26, 2024 •
edited
Loading

I'm one step ahead. Already added.

Reason was that other STORAGE_USERS envvars don't have it. But it makes sense in this case 👍

@kobergj kobergj requested a review from butonic June 26, 2024 16:54
@kobergj kobergj force-pushed the AllowDisableVersioning branch 3 times, most recently from 68ecb0c to 794d91d Compare June 27, 2024 08:59
@kobergj
Copy link
Collaborator Author

kobergj commented Jun 27, 2024

Slight change of approach:

  • storage-system uses hardcoded true for disable-versioning
  • storage-users can be configured via global OCIS_DISABLE_VERSIONING envvar. (default: false)

@kobergj kobergj force-pushed the AllowDisableVersioning branch from 794d91d to de0e618 Compare June 27, 2024 13:14
@kobergj kobergj requested a review from micbar June 27, 2024 13:15
micbar
micbar approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@micbar micbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kobergj kobergj enabled auto-merge June 27, 2024 13:21
@kobergj kobergj force-pushed the AllowDisableVersioning branch from de0e618 to dcac0cf Compare June 27, 2024 13:48
@kobergj
Copy link
Collaborator Author

kobergj commented Jun 27, 2024

no code changes - only rebased to master

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@kobergj kobergj merged commit 49287f5 into owncloud:master Jun 27, 2024
3 checks passed
@kobergj kobergj deleted the AllowDisableVersioning branch June 27, 2024 15:26
ownclouders pushed a commit that referenced this pull request Jun 27, 2024
@kobergj
Merge pull request #9473 from kobergj/AllowDisableVersioning
74214eb 
Allow to disable versioning
@micbar micbar mentioned this pull request Jul 8, 2024
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmattel mmattel mmattel left review comments

@micbar micbar micbar approved these changes

@butonic butonic Awaiting requested review from butonic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metadata storage creates file revision for every upload
4 participants
@kobergj @mmattel @butonic @micbar