Log user agent and remote addr on auth errors #9475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we also have some information available which definitely identifies a single user? I would like to have it in here. Like uid, username etc. None of the information added in here provides this now as even the address might be NATed and thus not unique. |
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
log-useragent-and-remoteaddr
branch
from
de08f92 to
b2255bb
Compare
|
we could log the token but when it is opaque we don't gain anything. The root cause of the error will be logged. AFAICT an error only occurs here when the idp is unreachable or the claims cannot be parsed. when the proxy is running at debug level the claims (including the user id) will be logged on successful auth. |
|
micbar
approved these changes
Jul 16, 2024
ownclouders
pushed a commit
that referenced
this pull request
Jul 16, 2024
Log user agent and remote addr on auth errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proxy will now log
user_agent,client.address,network.peer.addressandnetwork.peer.portto help operations debug authentication errors. The latter three follow the Semantic Conventions 1.26.0 / General / Attributes naming to better integrate with log aggregation tools.Trying to help pin down the occurrence very old access tokens... like 120+ days.