Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] bump reva #9621

Merged
merged 2 commits into from
Jul 17, 2024
Merged

[full-ci] bump reva #9621

merged 2 commits into from
Jul 17, 2024

Conversation

butonic
Copy link
Member

@butonic butonic commented Jul 16, 2024

ocis CI test run for cs3org/reva#4741

Fixes #9498
Fixes #9399

@butonic butonic self-assigned this Jul 16, 2024
@butonic butonic force-pushed the bump-reva-af606e7f branch from d55d47b to b59a052 Compare July 16, 2024 11:13
@kobergj kobergj changed the title bump reva [full-ci] bump reva Jul 16, 2024
@kobergj kobergj force-pushed the bump-reva-af606e7f branch from b59a052 to bce8f67 Compare July 16, 2024 13:27
@kobergj
Copy link
Collaborator

kobergj commented Jul 16, 2024

@butonic I'll take this over. I need a reva bump too

Copy link
Collaborator

@kobergj kobergj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@kobergj kobergj marked this pull request as ready for review July 16, 2024 13:29
@kobergj
Copy link
Collaborator

kobergj commented Jul 16, 2024

Still failing tests.
E2E test fails because the default for an archive is now "zip"

1) Scenario: download space (attempt 1, retried) # tests/e2e/cucumber/features/spaces/downloadSpace.feature:6
   ✔ Before # tests/e2e/cucumber/environment/index.ts:44
   ✔ Given "Admin" creates following users using API # tests/e2e/cucumber/steps/api.ts:7
       | id    |
       | Alice |
       | Brian |
   ✔ And "Admin" assigns following roles to the users using API # tests/e2e/cucumber/steps/api.ts:19
       | id    | role        |
       | Alice | Space Admin |
   ✔ And "Alice" logs in # tests/e2e/cucumber/steps/ui/session.ts:45
   ✔ And "Alice" creates the following project spaces using API # tests/e2e/cucumber/steps/api.ts:167
       | name | id     |
       | team | team.1 |
   ✔ And "Alice" creates the following folder in space "team" using API # tests/e2e/cucumber/steps/api.ts:221
       | name        |
       | spaceFolder |
   ✔ And "Alice" creates the following file in space "team" using API # tests/e2e/cucumber/steps/api.ts:181
       | name                  | content    |
       | spaceFolder/lorem.txt | space team |
   ✔ And "Alice" navigates to the project space "team.1" # tests/e2e/cucumber/steps/ui/spaces.ts:37
   ✖ When "Alice" downloads the space "team.1" # tests/e2e/cucumber/steps/ui/spaces.ts:209
       Error: expect(received).toContain(expected) // indexOf

       Expected substring: "download.tar"
       Received string:    "download.zip"
           at Proxy.<anonymous> (/drone/src/webTestRunner/node_modules/.pnpm/[email protected]/node_modules/playwright/lib/matchers/expect.js:177:37)
           at World.<anonymous> (/drone/src/webTestRunner/tests/e2e/cucumber/steps/ui/spaces.ts:215:32)
   - And "Alice" adds following users to the project space # tests/e2e/cucumber/steps/ui/spaces.ts:85
       | user  | role     | kind |
       | Brian | Can edit | user |
   - And "Alice" logs out # tests/e2e/cucumber/steps/ui/session.ts:58
   - And "Brian" logs in # tests/e2e/cucumber/steps/ui/session.ts:45
   - And "Brian" navigates to the project space "team.1" # tests/e2e/cucumber/steps/ui/spaces.ts:37
   - When "Brian" downloads the space "team.1" # tests/e2e/cucumber/steps/ui/spaces.ts:209
   - And "Brian" logs out # tests/e2e/cucumber/steps/ui/session.ts:58
   ✔ After # tests/e2e/cucumber/environment/index.ts:112

API test fails with other issue.

  @issue-1755
  Scenario: sharer uploads a file with checksum and as a sharee overwrites the shared file with new data and invalid checksum                                                                                                                    # /drone/src/tests/acceptance/features/apiSpacesShares/shareUploadTUS.feature:364
    Given user "Alice" has created a new TUS resource for the space "Personal" with content "" using the WebDAV API with these headers:                                                                                                          # SpacesTUSContext::userHasCreatedANewTusResourceForTheSpaceUsingTheWebdavApiWithTheseHeaders()
      | Upload-Length   | 16                        |
      | Upload-Metadata | filename dGV4dEZpbGUudHh0 |
      | Tus-Resumable   | 1.0.0                     |
    And user "Alice" has uploaded file with checksum "SHA1 c1dab0c0864b6ac9bdd3743a1408d679f1acd823" to the last created TUS Location with offset "0" and content "original content" via TUS inside of the space "Personal" using the WebDAV API # SpacesTUSContext::userHasUploadedFileWithChecksumToTheLastCreatedTusLocationWithOffsetAndContentViaTusInsideOfTheSpaceUsingTheWebdavApi()
    And user "Alice" has sent the following resource share invitation:                                                                                                                                                                           # SharingNgContext::userHasSentTheFollowingResourceShareInvitation()
      | resource        | textFile.txt |
      | space           | Personal     |
      | sharee          | Brian        |
      | shareType       | user         |
      | permissionsRole | File Editor  |
    When user "Brian" overwrites recently shared file with offset "0" and data "overwritten content" with checksum "SHA1 fe990d2686a0fc86004efc31f5bf2475a45d4906" via TUS inside of the space "Shares" using the WebDAV API with these headers: # SpacesTUSContext::userOverwritesRecentlySharedFileWithOffsetAndDataWithChecksumViaTusInsideOfTheSpaceUsingTheWebdavApiWithTheseHeaders()
      | Upload-Length   | 19                        |
      | Upload-Metadata | filename dGV4dEZpbGUudHh0 |
      | Tus-Resumable   | 1.0.0                     |
    Then the HTTP status code should be "460"                                                                                                                                                                                                    # FeatureContext::thenTheHTTPStatusCodeShouldBe()
      HTTP status code 204 is not the expected value 460
      Failed asserting that 204 matches expected '460'.
    And for user "Alice" the content of the file "/textFile.txt" of the space "Personal" should be "original content"                                                                                                                            # SpacesContext::checkFileContent()

Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@kobergj kobergj force-pushed the bump-reva-af606e7f branch from 8ec797e to 86c17e2 Compare July 17, 2024 08:13
Copy link

@kobergj kobergj merged commit de194c7 into master Jul 17, 2024
4 checks passed
@kobergj kobergj deleted the bump-reva-af606e7f branch July 17, 2024 08:42
ownclouders pushed a commit that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants