Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Remove config options that ain't available in web anymore #9679

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

AlexAndBear
Copy link
Contributor

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@AlexAndBear AlexAndBear requested a review from kulmann as a code owner July 23, 2024 12:27
Copy link

update-docs bot commented Jul 23, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear requested a review from kulmann July 23, 2024 12:34
@AlexAndBear AlexAndBear changed the title Remove config options that ain't available in web anymore [full-ci] Remove config options that ain't available in web anymore Jul 23, 2024
@AlexAndBear AlexAndBear force-pushed the purge-unavailable-config-options branch from fc39abb to 724fa31 Compare July 23, 2024 12:38
@ScharfViktor
Copy link
Contributor

Screenshot 2024-07-23 at 16 01 37

I guess we need owncloud/web@89f3cb0

@AlexAndBear
Copy link
Contributor Author

@ScharfViktor I have no idea how to bring it in, do we need a new web release ? :O

@ScharfViktor
Copy link
Contributor

@ScharfViktor I have no idea how to bring it in, do we need a new web release ? :O

Let's see what CI has to say. If we have failed tests again, we'll need to make a new web release

@ScharfViktor
Copy link
Contributor

now this test is green https://drone.owncloud.com/owncloud/ocis/37429/55/9

@AlexAndBear AlexAndBear force-pushed the purge-unavailable-config-options branch 2 times, most recently from d498b5c to 2224cf2 Compare July 23, 2024 16:38
@AlexAndBear AlexAndBear force-pushed the purge-unavailable-config-options branch from 6beeab3 to 552f5c8 Compare July 24, 2024 06:39
@AlexAndBear AlexAndBear requested a review from kulmann July 24, 2024 06:39
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you 🥇

Copy link

@AlexAndBear AlexAndBear merged commit 9867a93 into master Jul 24, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Jul 24, 2024
[full-ci] Remove config options that ain't available in web anymore
@micbar micbar mentioned this pull request Jul 30, 2024
20 tasks
@ScharfViktor ScharfViktor deleted the purge-unavailable-config-options branch December 16, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants