Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-only] update ocm service readme #9814

Merged
merged 3 commits into from
Aug 19, 2024
Merged

[docs-only] update ocm service readme #9814

merged 3 commits into from
Aug 19, 2024

Conversation

butonic
Copy link
Member

@butonic butonic commented Aug 14, 2024

I tried to make the setup and what goes inside the ocmproviders file clearer.

@@ -57,8 +127,12 @@ The data backend of the `ocminvitemanager` is configurable. The only supported b

## Creating Shares

{{< hint info >}}
The below info is outdated as we allow creating federated shares using the graph API. Clients can now discover the available sharing roles and invite federated users using the graph API.
{{< /hint >}}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a rework:

  • link to libre graph api docs
  • hm use existing examples from there?
  • prose

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a typo :)

services/ocm/README.md Outdated Show resolved Hide resolved
@butonic butonic requested a review from phil-davis August 16, 2024 13:09
@butonic butonic enabled auto-merge August 16, 2024 13:09
@butonic butonic self-assigned this Aug 16, 2024
services/ocm/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with @butonic LGTM 👍

Copy link

@butonic butonic merged commit 914f6f1 into master Aug 19, 2024
2 checks passed
@mmattel mmattel deleted the update-ocm-docs branch August 19, 2024 14:36
ownclouders pushed a commit that referenced this pull request Aug 19, 2024
[docs-only] update ocm service readme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants