Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Remove aria-described-by in tippy for a11y reasons #1531

Merged
merged 2 commits into from
Jul 26, 2021
Merged

Remove aria-described-by in tippy for a11y reasons #1531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d84a41c
Remove aria-describ-by in tippy for a11y reasons
lookacat Jul 23, 2021
68a1efd
adjusted snapshots
lookacat Jul 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/enhancement-oc-drop-remove-aria-describeby
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Enhancement: OcDrop remove aria-describedby

The aria-describedby-Attribute which triggers the output should be removed, so
that screenreaders don't read out the whole content on focus.

https://github.com/owncloud/web/issues/5398
3 changes: 0 additions & 3 deletions src/components/OcDrop.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,9 +106,6 @@ export default {
interactive: true,
plugins: [hideOnEsc],
theme: "none",
aria: {
content: "describedby",
},
onShow(instance) {
hideAll({ exclude: instance })
},
Expand Down
2 changes: 0 additions & 2 deletions src/components/__snapshots__/OcDrop.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
exports[`OcDrop renders tippy 1`] = `
<div>
<p
aria-describedby="tippy-3"
aria-expanded="true"
id="trigger"
>
Expand Down Expand Up @@ -96,7 +95,6 @@ exports[`OcDrop renders tippy 2`] = `
exports[`OcDrop renders tippy 3`] = `
<div>
<p
aria-describedby="tippy-3"
aria-expanded="true"
id="trigger"
>
Expand Down