This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Use pointer cursor for OcSelect actions #1604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kulmann
reviewed
Aug 23, 2021
|
Edited a few minutes ago and added this sentence: |
Voting for |
dschmidt
force-pushed
the
default_cursor_on_oc_select_actions
branch
from
dbe6594 to
cb5b321
Compare
dschmidt
changed the title
|
Switched to |
|
Kudos, SonarCloud Quality Gate passed!
|
kulmann
approved these changes
Aug 23, 2021
delete-merged-branch
bot
deleted the
default_cursor_on_oc_select_actions
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I changed the cursor for the actions (usually the down/up arrows) on
OcSelecttodefault.Related Issue
Motivation and Context
Currently a
textcursor is shown for the down/up arrows inOcSelectwhich is confusing because clicking it does not trigger a text edit but expands/collapses the drop down menu.Alternatively a
pointercursor (like for the "clear-X") could be used. My chromium on Linux usesdefaultfor regular<select>tags fwiw.I can add a changelog entry if you otherwise approve this PR.
How Has This Been Tested?
Screenshots (if appropriate):
before:
after:
Types of changes
Checklist:
Open tasks: