This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
A11y fix skip areas #1773
Merged
A11y fix skip areas #1773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
pascalwengerter
suggested changes
Nov 15, 2021
src/components/OcSidebarNav.vue
Outdated
| @@ -71,7 +71,7 @@ export default { | |||
| padding: var(--oc-space-large) 0 var(--oc-space-medium); | |||
| width: var(--oc-size-width-medium); | |||
|
|
|||
| &-header { | |||
| &-figure { | |||
There was a problem hiding this comment.
Since you didn't change the class in line 10 in src/components/OcSidebarNav.spec.js this change is not needed
pascalwengerter
approved these changes
Jan 25, 2022
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced
headerelement in sidebar navigation withfigureelement in order to avoid having twoheaderelements on the same page.Related Issue
How Has This Been Tested?
Types of changes
Checklist: