Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Add cancel-button and -handler to search component #2328

Merged
merged 4 commits into from
Sep 22, 2022
Merged

Add cancel-button and -handler to search component #2328

merged 4 commits into from
Sep 22, 2022

Conversation

JammingBen
Copy link
Contributor

Description

We've added to possibility to have a "cancel"-button and -handler in the OcSearchBar component.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Sep 22, 2022
@owncloud owncloud deleted a comment from update-docs bot Sep 22, 2022
@JammingBen JammingBen marked this pull request as ready for review September 22, 2022 13:24
@AlexAndBear
Copy link

Can we have an example in the templates ?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit 81e6eb2 into master Sep 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the cancel-search branch September 22, 2022 14:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@lookacat lookacat Awaiting requested review from lookacat

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JammingBen @AlexAndBear