Skip to content
This repository was archived by the owner on Jun 5, 2024. It is now read-only.

Commit

Permalink
Change: Move deps to peerDependencies
Browse files Browse the repository at this point in the history
  • Loading branch information
pascalwengerter committed Feb 8, 2022
1 parent 693d820 commit 22f006c
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 12 deletions.
9 changes: 9 additions & 0 deletions changelog/unreleased/change-peerdependencies
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
Change: Use peerDependencies instead of dependencies

In the past, we used dependencies in package.json which lead to a big bundle size and increased the possibility
that the same package with 2 different versions is part of the final bundle of the consuming application.

From now on, dependencies that are required to use the SDK are added to the peerDependencies section in package.json.
The consuming application then has to add the dependency on its own and can decide which minor or bugfix version to use.

https://github.com/owncloud/owncloud-sdk/pull/979
33 changes: 21 additions & 12 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,42 +68,51 @@
"not OperaMini all",
"not OperaMobile > 0"
],
"dependencies": {
"axios": "^0.25.0",
"cross-fetch": "^3.0.6",
"promise": "^8.0.3",
"qs": "^6.10.3",
"semver": "^7.3.5",
"utf8": "^3.0.0",
"uuid": "^8.2.0",
"webdav": "4.6.0",
"xml-js": "^1.6.11"
},
"devDependencies": {
"@babel/core": "^7.4.4",
"@babel/polyfill": "^7.4.4",
"@babel/preset-env": "^7.4.4",
"@pact-foundation/pact": "10.0.0-beta.36",
"axios": "^0.25.0",
"babel-loader": "^8.0.5",
"chai": "^4.2.0",
"chai-as-promised": "^7.1.1",
"codecov": "^3.3.0",
"cross-fetch": "^3.0.6",
"depcheck": "^1.4.3",
"eslint": "^7.32.0",
"eslint-config-standard": "^14.1.1",
"eslint-loader": "^4.0.2",
"eslint-plugin-import": "^2.17.2",
"eslint-plugin-import": "^2.25.4",
"eslint-plugin-jasmine": "^4.1.0",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-promise": "^4.3.1",
"eslint-plugin-standard": "^4.0.0",
"jasmine-data-provider": "^2.2.0",
"jest": "^26.6.3",
"jsdoc": "^3.6.1",
"promise": "^8.0.3",
"qs": "^6.10.3",
"semver": "^7.3.5",
"sync-fetch": "^0.3.0",
"utf8": "^3.0.0",
"uuid": "^8.2.0",
"webdav": "4.6.0",
"webpack": "^4.30.0",
"webpack-cli": "^3.3.2",
"webpack-node-externals": "^1.7.2",
"xml-js": "^1.6.11",
"xml2js": "^0.4.23"
},
"peerDependencies": {
"axios": "^0.25.0",
"cross-fetch": "^3.0.6",
"promise": "^8.0.3",
"qs": "^6.10.3",
"semver": "^7.3.5",
"utf8": "^3.0.0",
"uuid": "^8.2.0",
"webdav": "4.6.0",
"xml-js": "^1.6.11"
}
}

0 comments on commit 22f006c

Please sign in to comment.