Skip to content
This repository was archived by the owner on Jun 5, 2024. It is now read-only.

Change to webDavV2 + cleanup #962

Merged
merged 5 commits into from
Jan 26, 2022
Merged

Change to webDavV2 + cleanup #962

merged 5 commits into from
Jan 26, 2022

Conversation

AlexAndBear
Copy link

@AlexAndBear AlexAndBear commented Jan 25, 2022 •
edited by JammingBen
Loading

fixes #958

@JammingBen JammingBen force-pushed the drop-webdav-v1-support branch 2 times, most recently from c5d12ce to 30f23b9 Compare January 25, 2022 14:46
@JammingBen JammingBen marked this pull request as ready for review January 25, 2022 14:50
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
11.7% 11.7% Duplication

@kulmann kulmann mentioned this pull request Jan 26, 2022
Closed
pascalwengerter
pascalwengerter reviewed Jan 26, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the version number in package.json to 2.0.0-alpha (or similiar) if it's a breaking change and add a changelog item (after rebase on master which now is on the usual semver/calens-changelog flow)

@AlexAndBear AlexAndBear force-pushed the drop-webdav-v1-support branch from a19394f to 9ad1c43 Compare January 26, 2022 14:04
kulmann
kulmann reviewed Jan 26, 2022
View reviewed changes
kulmann
kulmann reviewed Jan 26, 2022
View reviewed changes
@fschade
Copy link
Contributor

fschade commented Jan 26, 2022

Please do not merge before tomorrow, i wonder why the tests still pass even if we nearly changed all routes.

cc.: @individual-it, can you give us a short onboarding for pact tomorrow?

@JammingBen
Copy link
Contributor

i wonder why the tests still pass even if we nearly changed all routes.

Because we also adjusted the tests 😄 Basically all /remote.php/webdav/... -> /remote.php/dav/files/${testUser}/...

@fschade
Copy link
Contributor

fschade commented Jan 26, 2022

nice, thanks for bringing light into the dark :) so lets see what next test run says

@fschade
Copy link
Contributor

fschade commented Jan 26, 2022

ci fails now, alpha release postponed to tomorrow

@JammingBen
Copy link
Contributor

It fails because you've updated pact to 10.0.0-beta.54. We cannot use that version (yet at least), see #961 (comment).

fschade
fschade approved these changes Jan 26, 2022
View reviewed changes
Copy link
Contributor

@fschade fschade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@fschade fschade merged commit 92694aa into master Jan 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the drop-webdav-v1-support branch January 26, 2022 17:42
@AlexAndBear
Copy link
Author

(after rebase on master which now is on the usual semver/calens-changelog flow)

Aaaaand it was merged without the changelog :D

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kulmann kulmann kulmann left review comments

@pascalwengerter pascalwengerter pascalwengerter left review comments

@fschade fschade fschade approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@AlexAndBear AlexAndBear

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop support for webdav v1
5 participants
@AlexAndBear @fschade @JammingBen @kulmann @pascalwengerter