Decrease linter errors, keep commented tests warnings (#7581)

* Decrease linter errors, keep commented tests warnings
owncloud · Sep 2, 2022 · 50a0ba2 · 50a0ba2
1 parent af8b72f
commit 50a0ba2
Show file tree

Hide file tree

Showing 12 changed files with 26 additions and 25 deletions.
diff --git a/packages/web-app-external/tests/unit/app.spec.ts b/packages/web-app-external/tests/unit/app.spec.ts
@@ -113,7 +113,7 @@ describe('The app provider extension', () => {
   it('should show a loading spinner while loading', async () => {
     const makeRequest = jest.fn(
       () =>
-        new Promise((resolve, reject) => {
+        new Promise((resolve) => {
           setTimeout(() => {
             resolve({
               ok: true,

diff --git a/packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue b/packages/web-app-files/src/components/SideBar/Shares/FileLinks.vue
@@ -407,7 +407,7 @@ export default defineComponent({
       const paramsToCreate = this.getParamsForLink(link)
 
       if (this.isPasswordEnforcedFor(link)) {
-        showQuickLinkPasswordModal({ store: this.$store }, async (newPassword) => {
+        showQuickLinkPasswordModal({ store: this.$store }, (newPassword) => {
           this.createLink({ params: { ...paramsToCreate, password: newPassword }, onError })
         })
       } else {
@@ -419,7 +419,7 @@ export default defineComponent({
       const params = this.getParamsForLink(link)
 
       if (!link.password && this.isPasswordEnforcedFor(link)) {
-        showQuickLinkPasswordModal({ store: this.$store }, async (newPassword) => {
+        showQuickLinkPasswordModal({ store: this.$store }, (newPassword) => {
           this.updatePublicLink({ params: { ...params, password: newPassword }, onSuccess })
         })
       } else {

diff --git a/packages/web-app-files/src/components/SideBar/Shares/FileShares.vue b/packages/web-app-files/src/components/SideBar/Shares/FileShares.vue
@@ -320,7 +320,7 @@ export default {
       )
     }
   },
-  async mounted() {
+  mounted() {
     if (this.showSpaceMembers) {
       this.loadSpaceMembersTask.perform()
     }

diff --git a/packages/web-app-files/src/helpers/resource/copyMove.ts b/packages/web-app-files/src/helpers/resource/copyMove.ts
@@ -269,7 +269,7 @@ export const resolveFileNameDuplicate = (name, extension, existingFiles, iterati
   return resolveFileNameDuplicate(name, extension, existingFiles, iteration + 1)
 }
 
-const clientListFilesInFolder = async (
+const clientListFilesInFolder = (
   client: any,
   webDavPath: string,
   depth: number,
@@ -282,7 +282,7 @@ const clientListFilesInFolder = async (
   return client.files.list(webDavPath, depth, DavProperties.Default)
 }
 
-const clientMoveFilesInFolder = async (
+const clientMoveFilesInFolder = (
   client: any,
   webDavPathSource: string,
   webDavPathTarget: string,
@@ -301,7 +301,7 @@ const clientMoveFilesInFolder = async (
   return client.files.move(webDavPathSource, webDavPathTarget, overwrite)
 }
 
-const clientCopyFilesInFolder = async (
+const clientCopyFilesInFolder = (
   client: any,
   webDavPathSource: string,
   webDavPathTarget: string,

diff --git a/packages/web-app-files/src/store/actions.ts b/packages/web-app-files/src/store/actions.ts
@@ -64,7 +64,7 @@ export default {
       { root: true }
     )
   },
-  async clearClipboardFiles(context) {
+  clearClipboardFiles(context) {
     context.commit('CLEAR_CLIPBOARD')
   },
   async pasteSelectedFiles(

diff --git a/packages/web-app-files/src/views/FilesDrop.vue b/packages/web-app-files/src/views/FilesDrop.vue
@@ -133,7 +133,6 @@ export default defineComponent({
 
     resolvePublicLink() {
       this.loading = true
-
       this.$client.publicFiles
         .list(this.publicLinkToken, this.publicLinkPassword, DavProperties.PublicLink, '0')
         .then((files) => {

diff --git a/packages/web-app-files/tests/unit/helpers/resource/copyMove.spec.ts b/packages/web-app-files/tests/unit/helpers/resource/copyMove.spec.ts
@@ -42,14 +42,14 @@ describe('copyMove', () => {
   ])('should copy and move files if no conflicts exist', async (dataSet) => {
     const client = {
       files: {
-        list: async () => {
+        list: () => {
           return []
         },
         copy: jest.fn(),
         move: jest.fn()
       },
       publicFiles: {
-        list: async () => {
+        list: () => {
           return []
         },
         copy: jest.fn(),

diff --git a/packages/web-app-files/tests/unit/views/FilesDrop.spec.js b/packages/web-app-files/tests/unit/views/FilesDrop.spec.js
@@ -15,16 +15,19 @@ localVue.use(GetTextPlugin, {
 localVue.prototype.$client.publicFiles = {
   PUBLIC_LINK_SHARE_OWNER: 'admin',
   // function is mocked because it should return a promise with a list of resources
-  list: async () => [
-    {
-      getProperty: jest.fn((val) => {
-        if (val === DavProperty.PublicLinkPermission) {
-          return linkRoleUploaderFolder.bitmask(false)
+  list: () =>
+    new Promise((resolve) => {
+      resolve([
+        {
+          getProperty: jest.fn((val) => {
+            if (val === DavProperty.PublicLinkPermission) {
+              return linkRoleUploaderFolder.bitmask(false)
+            }
+            return val
+          })
         }
-        return val
-      })
-    }
-  ],
+      ])
+    }),
   // function takes token as an argument and is mocked because it should return some public link url
   getFileUrl: (token) => `http://some-url/${token}`,
   putFileContents: jest.fn()

diff --git a/packages/web-app-user-management/src/search/filter/index.ts b/packages/web-app-user-management/src/search/filter/index.ts
@@ -37,7 +37,7 @@ export default class Provider extends EventBus implements SearchProvider {
     }
   }
 
-  public activate(term: string): void {
+  public activate(): void {
     /* noop */
   }
 

diff --git a/packages/web-pkg/src/composables/appDefaults/useAppFileHandling.ts b/packages/web-pkg/src/composables/appDefaults/useAppFileHandling.ts
@@ -13,7 +13,6 @@ interface AppFileHandlingOptions {
   publicLinkPassword: MaybeRef<string>
 }
 
-type QueryParameters = Record<string, string>
 export interface AppFileHandlingResult {
   getUrlForResource(r: Resource): Promise<string>
   revokeUrl(url: string): void

diff --git a/packages/web-runtime/src/container/bootstrap.ts b/packages/web-runtime/src/container/bootstrap.ts
@@ -305,7 +305,7 @@ export const announceUppyService = ({ vue }: { vue: VueConstructor }): void => {
  * @param store
  * @param router
  */
-export const announceAuthService = async ({
+export const announceAuthService = ({
   vue,
   configurationManager,
   store,
@@ -315,7 +315,7 @@ export const announceAuthService = async ({
   configurationManager: ConfigurationManager
   store: Store<any>
   router: VueRouter
-}): Promise<void> => {
+}): void => {
   authService.initialize(configurationManager, clientService, store, router)
   set(vue, '$authService', authService)
 }

diff --git a/packages/web-runtime/src/index.ts b/packages/web-runtime/src/index.ts
@@ -82,7 +82,7 @@ export const renderSuccess = (): void => {
     (state, getters) => {
       return getters['runtime/auth/isUserContextReady']
     },
-    async (newValue, oldValue) => {
+    () => {
       // Load spaces to make them available across the application
       if (store.getters.capabilities?.spaces?.enabled) {
         const clientService = instance.$clientService
-Original file line number
+Diff line change
@@ Expand Up @@
         }
       }
-      public activate(term: string): void {
+      public activate(): void {
         /* noop */
       }
@@ Expand Down @@