Skip to content

Commit

Permalink
Show missing role name in link share panel (#12012)
Browse files Browse the repository at this point in the history
  • Loading branch information
AlexAndBear authored and Jannik Stehle committed Dec 9, 2024
1 parent e433be5 commit 671193c
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 1 deletion.
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
Bugfix: Show missing role name in link share panel

We've fixed a bug where the role name was missing in the link share panel.

https://github.com/owncloud/web/pull/12012
11 changes: 10 additions & 1 deletion packages/web-pkg/src/components/CreateLinkModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@
</div>
<div v-else class="oc-flex oc-flex-middle">
<oc-icon class="oc-mr-s" :name="selectedTypeIcon" fill-type="line" />
<span v-text="selectedTypeDescription" />
<div class="oc-flex oc-flex-column">
<span class="oc-text-bold" v-text="selectedTypeDisplayName" />
<span class="oc-text-small" v-text="selectedTypeDescription" />
</div>
</div>
<oc-button
v-if="!isAdvancedMode"
Expand Down Expand Up @@ -187,6 +190,11 @@ export default defineComponent({
const selectedTypeDescription = computed(() =>
$gettext(getLinkRoleByType(unref(selectedType)).description)
)
const selectedTypeDisplayName = computed(() =>
$gettext(getLinkRoleByType(unref(selectedType)).displayName)
)
const selectedTypeIcon = computed(() => getLinkRoleByType(unref(selectedType)).icon)
const availableLinkTypes = computed(() => getAvailableLinkTypes({ isFolder: unref(isFolder) }))
Expand Down Expand Up @@ -313,6 +321,7 @@ export default defineComponent({
availableLinkTypes,
selectedType,
selectedTypeIcon,
selectedTypeDisplayName,
selectedTypeDescription,
isSelectedLinkType,
updateSelectedLinkType,
Expand Down

0 comments on commit 671193c

Please sign in to comment.