Skip to content

Commit

Permalink
Refactor webUILogin/adminBlocksUser.feature::20 to make it follow the…
Browse files Browse the repository at this point in the history
… current behaviour (#8074)

use the user disabled page step

change the selector

fix lint

try with single selector
  • Loading branch information
SwikritiT authored Dec 13, 2022
1 parent ea9ac22 commit 67c6417
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,6 @@ Level-3 headings should be used for the references to the relevant issues. Inclu

Other free text and markdown formatting can be used elsewhere in the document if needed. But if you want to explain something about the issue, then please post that in the issue itself.

### [user session of a blocked user is not cleared properly](https://github.com/owncloud/web/issues/4795)
- [webUILogin/adminBlocksUser.feature:20](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUILogin/adminBlocksUser.feature#L20)

### [Comments in sidebar](https://github.com/owncloud/web/issues/1158)
- [webUIFilesDetails/fileDetails.feature:90](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L90)
- [webUIFilesDetails/fileDetails.feature:106](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIFilesDetails/fileDetails.feature#L106)
Expand All @@ -37,4 +34,4 @@ Other free text and markdown formatting can be used elsewhere in the document if
- [webUISharingAcceptShares/acceptShares.feature:31](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUISharingAcceptShares/acceptShares.feature#L31)

### [empty subfolder inside a folder to be uploaded is not created on the server](https://github.com/owncloud/web/issues/6348)
- [webUIUpload/upload.feature:43](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIUpload/upload.feature#L43)
- [webUIUpload/upload.feature:43](https://github.com/owncloud/web/blob/master/tests/acceptance/features/webUIUpload/upload.feature#L43)
4 changes: 3 additions & 1 deletion tests/acceptance/features/webUILogin/adminBlocksUser.feature
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,6 @@ Feature: view profile
@oauthLogin @notToImplementOnOCIS
Scenario: the user session of a blocked user is cleared properly using oauth authentication
When the user reloads the current page of the webUI
Then the user should be redirected to the user disabled page
Then the user should be redirected to the login error page
When the user exits the login error page
Then the user should be redirected to the login page
2 changes: 1 addition & 1 deletion tests/acceptance/pageObjects/loginPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module.exports = {
elements: {
body: 'body',
authenticateButton: {
selector: '//div/button/span[@class="MuiButton-label" and text()="Log in"]',
selector: "//button//span[text()='Login' or text()='Log in']",
locateStrategy: 'xpath'
}
},
Expand Down

0 comments on commit 67c6417

Please sign in to comment.