Fix unit tests

owncloud · Nov 16, 2021 · 96103b5 · 96103b5
1 parent 0846a70
commit 96103b5
Show file tree

Hide file tree

Showing 5 changed files with 79 additions and 76 deletions.
diff --git a/packages/web-app-files/src/components/AppBar/AppBar.vue b/packages/web-app-files/src/components/AppBar/AppBar.vue
@@ -99,7 +99,7 @@
             </oc-drop>
           </template>
           <size-info v-if="hasBulkActions && selectedFiles.length > 0" class="oc-mr uk-visible@l" />
-          <batch-actions v-if="hasBulkActions && selectedFiles.length > 0" />
+          <batch-actions v-if="hasBulkActions" />
         </div>
         <view-options />
       </div>

diff --git a/packages/web-app-files/tests/unit/components/AppBar/AppBar.spec.js b/packages/web-app-files/tests/unit/components/AppBar/AppBar.spec.js
@@ -93,7 +93,7 @@ describe('AppBar component', () => {
     const route = {
       name: page,
       params: {
-        // what's going on here?
+        // item is the link token for public links (root of the public link) vs. empty for personal page (root of the home)
         item: page === 'files-public-list' ? '6mfXfTtYHVxrlAu' : ''
       },
       meta: {
@@ -217,11 +217,11 @@ describe('AppBar component', () => {
 
     describe('when no items are selected', () => {
       it('should show batch actions but not size-info', () => {
-        // const batchActions = wrapper.find(elSelector.batchActions) // TODO: Fix this one
+        const batchActions = wrapper.find(elSelector.batchActions)
         const sizeInfo = wrapper.find(elSelector.sizeInfo)
 
         expect(sizeInfo.exists()).toBeFalsy()
-        // expect(batchActions.isVisible()).toBeTruthy() // TODO: Fix this one
+        expect(batchActions.isVisible()).toBeTruthy()
       })
     })
 
@@ -265,12 +265,13 @@ describe('AppBar component', () => {
           expect(newButton.exists()).toBeFalsy()
           expect(ocDrop.exists()).toBeFalsy()
         })
-        it('should not show batch actions and size-info', () => {
-          const batchActions = wrapper.find(elSelector.batchActions)
+        it('should not show size-info', () => {
           const sizeInfo = wrapper.find(elSelector.sizeInfo)
-
           expect(sizeInfo.exists()).toBeFalsy()
-          expect(batchActions.exists()).toBeFalsy()
+        })
+        it('should show batch actions', () => {
+          const batchActions = wrapper.find(elSelector.batchActions)
+          expect(batchActions.exists()).toBeTruthy()
         })
       })
 

diff --git a/packages/web-app-files/tests/unit/components/FilesList/ContextActions.spec.js b/packages/web-app-files/tests/unit/components/FilesList/ContextActions.spec.js
@@ -202,19 +202,21 @@ function getWrapper(route, { filename, extension, type = '', mimeType }, availab
       publicPage: () => false
     },
     propsData: {
-      item: {
-        id: 'a93f8adf==',
-        fileId: 'a93f8adf==',
-        name: filename,
-        path: type === 'file' ? `/${filename}.${extension}` : `/${filename}`,
-        mimeType,
-        extension,
-        type,
-        canDownload: () => true,
-        isReceivedShare: () => true,
-        canBeDeleted: () => true,
-        canRename: () => true
-      }
+      items: [
+        {
+          id: 'a93f8adf==',
+          fileId: 'a93f8adf==',
+          name: filename,
+          path: type === 'file' ? `/${filename}.${extension}` : `/${filename}`,
+          mimeType,
+          extension,
+          type,
+          canDownload: () => true,
+          isReceivedShare: () => true,
+          canBeDeleted: () => true,
+          canRename: () => true
+        }
+      ]
     },
     computed: {
       menuSections: () => mockMenuSections