React on code review

owncloud · Apr 13, 2022 · ba6547a · ba6547a
1 parent a259a60
commit ba6547a
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/packages/web-app-user-management/src/components/Groups/GroupsList.vue b/packages/web-app-user-management/src/components/Groups/GroupsList.vue
@@ -128,7 +128,7 @@ export default {
   },
   methods: {
     filter(groups, searchTerm) {
-      if (!searchTerm) {
+      if (!(searchTerm || '').trim()) {
         return groups
       }
       const groupsSearchEngine = new Fuse(groups, {

diff --git a/packages/web-app-user-management/src/components/Users/UsersList.vue b/packages/web-app-user-management/src/components/Users/UsersList.vue
@@ -147,7 +147,7 @@ export default {
   },
   methods: {
     filter(users, searchTerm) {
-      if (!searchTerm) {
+      if (!(searchTerm || '').trim()) {
         return users
       }
       const usersSearchEngine = new Fuse(users, {

diff --git a/packages/web-app-user-management/src/search/filter/index.ts b/packages/web-app-user-management/src/search/filter/index.ts
@@ -29,7 +29,12 @@ export default class Provider extends EventBus implements SearchProvider {
   }
 
   public get label(): string {
-    return $gettext(`Search ${kind(this.router.currentRoute)} ↵`)
+    switch (kind(this.router.currentRoute)) {
+      case 'users':
+        return $gettext('Search users ↵')
+      case 'groups':
+        return $gettext('Search groups ↵')
+    }
   }
 
   public activate(term: string): void {