reset user and dynamic nav items on logout

changelog/unreleased/bugfix-resetting-store-on-logout

@@ -0,0 +1,6 @@
+Bugfix: Resetting store on logout
+
+When logging out, only some parts of vuex store were reset to default. This caused bugs by switching to another account that has some other/missing settings. For example, if the account has no quota, the quota of the previously logged in account was shown. We have fixed this by resetting the user store module on logout with reset function (vuex extensions library) and creating an action to reset dynamic nav items.
+
+https://github.com/owncloud/web/pull/6694
+https://github.com/owncloud/web/issues/6549

packages/web-runtime/src/store/navigation.js

@@ -43,6 +43,10 @@ const mutations = {
     }
     state.dynamicNavItems = dynamicNavItems
   },
+  /* Sets dynamic nav items */
+  SET_DYNAMIC_NAV_ITEMS(state, navItems) {
+    state.dynamicNavItems = navItems
+  },
   SET_CLOSED(state, closed) {
     state.closed = closed
   }
@@ -89,6 +93,9 @@ const actions = {
   },
   closeNavigation({ commit }) {
     commit('SET_CLOSED', true)
+  },
+  clearDynamicNavItems({ commit }) {
+    commit('SET_DYNAMIC_NAV_ITEMS', {})
   }
 }
 export default {

packages/web-runtime/src/store/user.js

@@ -25,12 +25,11 @@ const actions = {
     if (context.state.id === '') {
       return
     }
-    // reset user to default state
-    context.commit('SET_USER', state)
-    // reset capabilities to default state
-    context.commit('SET_CAPABILITIES', { capabilities: null, version: null })
-    // set userReady to false
-    context.commit('SET_USER_READY', false)
+    // reset user
+    this.reset({ self: false, nested: false, modules: { user: { self: true } } })
+
+    // clear dynamic navItems
+    context.dispatch('clearDynamicNavItems')
 
     // clear oidc client state
     vueAuthInstance.clearLoginState()
@@ -42,9 +41,6 @@ const actions = {
       dispatch('hideModal')
       dispatch('loadSettingsValues')
 
-      // Reset store
-      this.reset()
-
       // Force redirect to login
       if (forceRedirect) {
         router.push({ name: 'login' })