Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document has no main content area #1652

Closed
LukasHirt opened this issue Jul 29, 2019 · 5 comments · Fixed by #4863
Closed

Document has no main content area #1652

LukasHirt opened this issue Jul 29, 2019 · 5 comments · Fixed by #4863
Assignees
Milestone

Comments

@LukasHirt
Copy link
Collaborator

No description provided.

@DeepDiver1975 DeepDiver1975 added the Priority:p4-low Low priority label Aug 16, 2019
@LukasHirt LukasHirt added this to the backlog milestone Aug 23, 2019
@marcus-herrmann marcus-herrmann self-assigned this Oct 4, 2019
@pascalwengerter
Copy link
Contributor

Closing this since we now have the Vue.js app wrapped in a <main> tag.

@marcus-herrmann
Copy link
Contributor

But is it wrapping the main content of the page or everything?

@marcus-herrmann
Copy link
Contributor

@pascalwengerter It looks like it is wrapping everything, and this is not how the main element is intended/could be a WCAG violation:

<main id="owncloud"></main>

@pascalwengerter
Copy link
Contributor

@marcus-herrmann sorry, was under the wrong impression that your commit had fixed it. How critical is fixing this for the accessibility certification?

@kulmann maybe we need to be solving this on the extension level, currently we're using <main> in web-container/index.html.ejs and web-runtime/src/App.vue (and from the definition below I'm not sure at which level we should be applying it, so are we wrapping extentions (e.g. draw-io) inside a <main> tag already or are they "bringing their own"?

The content inside the

element should be unique to the document. It should not contain any content that is repeated across documents such as sidebars, navigation links, copyright information, site logos, and search forms.

Note: There must not be more than one

element in a document.

@marcus-herrmann
Copy link
Contributor

How critical is fixing this for the accessibility certification?

@pascalwengerter Rather critical. Wrongly applied landmarks are worse than no landmarks at all. I'm quite certain this can be seen as a violation of WCAG SC 2.4.1, Bypass blocks.

My fix back in the day fixed this, but another <main> element wrapping it all, and one inside an app, wrapping the router is certainly difficult in an audit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants