Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:154 failing randomly #5660

Closed
LukasHirt opened this issue Aug 11, 2021 · 7 comments · Fixed by #5852
Closed
Assignees

Comments

@LukasHirt
Copy link
Collaborator

Another randomly failing scenario. Example https://drone.owncloud.com/owncloud/web/18187/28/14

@sakshamgurung
Copy link
Contributor

sakshamgurung commented Aug 25, 2021

@phil-davis After investigating it was found the problem with stale DOM reference.

Screenshot from 2021-08-25 13-24-57

So, what can we do? Refresh page after uploading file? or any other way?

@individual-it
Copy link
Member

@sakshamgurung stale reference does usually mean that the DOM changed and the test is trying to access to old DOM element, so we need to understand why that is happening. Why aren't we using the current DOM?

@pascalwengerter
Copy link
Contributor

Just had a debugging session on another CI issue (in #5725) with @kulmann and we saw a stale element reference also, but it turned out it wasn't the actual reason for failure. Maybe that is the case here also?

@saw-jan
Copy link
Member

saw-jan commented Sep 29, 2021

I can confirm that the cause of the failure for this scenario is stale element reference. This might occur due to DOM refresh.
For this particular case, I suspect, file preview is causing the DOM refresh.
I duplicated the scenario multiple times and tried adding @disablePreviews to the feature file, all the tests passed.

@saw-jan
Copy link
Member

saw-jan commented Sep 29, 2021

Just had a debugging session on another CI issue (in #5725) with @kulmann and we saw a stale element reference also, but it turned out it wasn't the actual reason for failure. Maybe that is the case here also?

For shareIndicator test step, the function that gets share-indicator will get retried once if the share-indicator is not found for the first time. If that happens then you are likely to see stale element reference error but the test will pass (if the retry passes).

@individual-it
Copy link
Member

individual-it commented Sep 29, 2021

For this particular case, I suspect, file preview is causing the DOM refresh.

this seems to be the case, according to @fschade the whole row is re-rendered when the preview is loaded

@individual-it
Copy link
Member

hopefully fixed in #5852

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants