Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only full-ci] disable previews in tests that check sharing indicators #5852

Merged
merged 1 commit into from
Sep 30, 2021
Merged

[tests-only full-ci] disable previews in tests that check sharing indicators #5852

merged 1 commit into from
Sep 30, 2021

Conversation

individual-it
Copy link
Member

@individual-it individual-it commented Sep 29, 2021 •
edited
Loading

Description

When the preview / thumbnail is loaded the whole row is replaced.
So if the tests check something else in the row during that time, they might crash with a stale element error.
For those cases disable previews.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@individual-it individual-it self-assigned this Sep 29, 2021
@individual-it individual-it force-pushed the disablePreview branch 2 times, most recently from 6e4779f to 523d001 Compare September 29, 2021 16:56
@ownclouders
Copy link
Contributor

Results for oC10SharingInternalUsersRoot1 https://drone.owncloud.com/owncloud/web/19296/29/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@individual-it individual-it changed the title [tests-only] disable previews in tests that check sharing indicators [tests-only full-ci] disable previews in tests that check sharing indicators Sep 29, 2021
@ownclouders
Copy link
Contributor

Results for oC10SharingAccept https://drone.owncloud.com/owncloud/web/19297/11/1
The following scenarios passed on retry:

  • webUISharingAcceptSharesToRoot/acceptShares.feature:108

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@individual-it individual-it mentioned this pull request Sep 29, 2021
Closed
@phil-davis phil-davis merged commit d1fe950 into master Sep 30, 2021
@delete-merged-branch delete-merged-branch bot deleted the disablePreview branch September 30, 2021 02:16
@saw-jan saw-jan mentioned this pull request Sep 30, 2021
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@fschade fschade Awaiting requested review from fschade

@kulmann kulmann Awaiting requested review from kulmann

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

@sakshamgurung sakshamgurung Awaiting requested review from sakshamgurung

Assignees

@individual-it individual-it

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QA] webUISharingInternalUsersSharingIndicator/shareWithUsers.feature:154 failing randomly
3 participants
@individual-it @ownclouders @phil-davis