Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs don't resolve conflicting spaces / are only path based #7799

Closed
kulmann opened this issue Oct 14, 2022 · 3 comments · Fixed by #11201
Closed

Breadcrumbs don't resolve conflicting spaces / are only path based #7799

kulmann opened this issue Oct 14, 2022 · 3 comments · Fixed by #11201
Assignees
Labels

Comments

@kulmann
Copy link
Contributor

kulmann commented Oct 14, 2022

Followup of #7725

Breadcrumbs are currently built from parent paths segments (i.e. only path based, no fileIds present). As a result, the breadcrumbs might resolve to the wrong space if you have two or more spaces with identical drive aliases (drive alias clashes are allowed, we need fileIds to resolve the correct space).

To solve this we need a sequence of propfinds, with each propfind being on the fileId of a folder and requesting the respective parent folder id, until we reached the root of the space.

Side note: we can collect the shareTypes of all parent folders as well. This would resolve the issue that we currently request all shares via OCS. Doesn't need to be implemented in the same PR, but should be prepared.

@tbsbdr
Copy link

tbsbdr commented Oct 14, 2022

imo cornercase but consequences could be really ugly. I need to real-time talk with you about this to give it a proper prio.

@kulmann
Copy link
Contributor Author

kulmann commented Oct 14, 2022

Turns out: the breadcrumbs work correct without the fileId because we already have a resolved space (from DriveResolver.vue component / useDriveResolver composable) and when the drive alias doesn't change we don't try to re-resolve the space. We only extract the updated relative item path. The fileId gets added back to the URL (because we have a mechanism in place that does that). Definitely not a GA blocker, everything works. Just could be "more precise" with the fileId already being in the route to the parent folder. No other added value.

@JammingBen JammingBen mentioned this issue Sep 13, 2023
39 tasks
@kulmann kulmann moved this from Qualification to Refactor / Technical Debt in Infinite Scale Team Board Jun 4, 2024
@kulmann kulmann added the Priority:p4-low Low priority label Jun 4, 2024
@kulmann
Copy link
Contributor Author

kulmann commented Jun 4, 2024

We have the ancestorMetaData available in the resource pinia store by now. That is all the information we need (a fileId for each and every parent folder up to the space root). The function which builds breadcrumb items needs to be refactored to take the fileIds into account as well. But as already stated, prio is really really low because it fixes no bug at all.

@JammingBen JammingBen self-assigned this Jul 8, 2024
@github-project-automation github-project-automation bot moved this from Refactor / Technical Debt to Done in Infinite Scale Team Board Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants