-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breadcrumbs don't resolve conflicting spaces / are only path based #7799
Comments
imo cornercase but consequences could be really ugly. I need to real-time talk with you about this to give it a proper prio. |
Turns out: the breadcrumbs work correct without the |
We have the |
Followup of #7725
Breadcrumbs are currently built from parent paths segments (i.e. only path based, no fileIds present). As a result, the breadcrumbs might resolve to the wrong space if you have two or more spaces with identical drive aliases (drive alias clashes are allowed, we need fileIds to resolve the correct space).
To solve this we need a sequence of propfinds, with each propfind being on the fileId of a folder and requesting the respective parent folder id, until we reached the root of the space.
Side note: we can collect the
shareTypes
of all parent folders as well. This would resolve the issue that we currently request all shares via OCS. Doesn't need to be implemented in the same PR, but should be prepared.The text was updated successfully, but these errors were encountered: