Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wip] id-based webdav requests #11180

Closed
wants to merge 3 commits into from
Closed

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Jul 11, 2024

Description

Introduce id-based webdav requests. This is the recommended way to work with the webdav API according to oCIS because it delivers better performance, especially with slower storages.

This is quite a big PR that tries to gather all relevant changes. The plan is to divide it into smaller parts and create separate PRs. I'm not 100% sure of we can (or should) fully switch to id-based webdav requests yet. But there are definitely parts of it that make sense to do now.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Jul 11, 2024
Copy link

update-docs bot commented Jul 11, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen JammingBen changed the title refactor: id-based webdav requests refactor: id-based webdav requests for listings Jul 11, 2024
@JammingBen JammingBen force-pushed the id-based-webdav-requests branch 2 times, most recently from c1d2c3c to b1abb65 Compare July 11, 2024 14:26
Copy link

@JammingBen JammingBen force-pushed the id-based-webdav-requests branch 7 times, most recently from 32748a8 to 49f3265 Compare July 12, 2024 13:07
Introduce id-based webdav requests for space and folder listings. This is the recommended way to work with the webdav API according to oCIS because it delivers better performance, especially with slower storages.

Some of the webdav operations still need path handling though. Because of that, this change still "injects" full resources paths in the space loader. This can (hopefully) be removed once all operations work id-based or when we make the switch to Graph.
@JammingBen JammingBen force-pushed the id-based-webdav-requests branch from 49f3265 to 414f588 Compare July 12, 2024 14:05
@JammingBen JammingBen changed the title refactor: id-based webdav requests for listings refactor: id-based webdav requests Jul 12, 2024
@JammingBen JammingBen changed the title refactor: id-based webdav requests [wip] id-based webdav requests Jul 15, 2024
@JammingBen
Copy link
Contributor Author

Closing since we'll never merge this PR. It's only a reference for me what still needs to be done on the road to id-based webdav requests.

@JammingBen JammingBen closed this Jul 17, 2024
@kulmann kulmann deleted the id-based-webdav-requests branch September 5, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant