Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Design] Make the instance logo work on light and dark backgrounds #8425

Closed
michaelstingl opened this issue Feb 13, 2023 · 3 comments · Fixed by #8522
Closed

[Design] Make the instance logo work on light and dark backgrounds #8425

michaelstingl opened this issue Feb 13, 2023 · 3 comments · Fixed by #8522

Comments

@michaelstingl
Copy link
Contributor

@tbsbdr Default instance logo (themes/owncloud/assets/logo.svg) is a white cloud with transparent background. To use it universally in desktop and mobile apps, we should make it more robust, so it can be used on dark and light backgrounds.

@tbsbdr
Copy link

tbsbdr commented Mar 1, 2023

Proposal

General:

  • oC Logo with blue background (robust as it works on all backgrounds, ex. in Desktop Client)

Web:

  • oC Logo with transparent background (works on dark & light mode in web)

@hurradieweltgehtunter
Copy link
Contributor

hurradieweltgehtunter commented Mar 2, 2023

see here: #8522
IMO we cannot alter the bright logo due to trademark restrictions. Instead we need to use a dark variant, which is added in this PR
@michaelstingl does this help you?

@kulmann
Copy link
Contributor

kulmann commented Mar 2, 2023

Just to be clear, how should the logo upload feature in the admin settings behave? Should it replace all of the logos? And if you want to do fancy stuff like having one logo in the common section and another one in the web section you can only do that by manually altering the theme. Correct? @tbsbdr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants