-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dark ownCloud logo #8522
add dark ownCloud logo #8522
Conversation
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please change the file reference for the logo in the common
section of the default theme to this file? That way the other clients can pick up this new variant of the logo.
here:
https://github.com/owncloud/web/blob/master/packages/web-runtime/themes/owncloud/theme.json#L5
The purpose of this PR is to just provide a dark logo, so one could use it if needed. I'm not sure if we should change the default one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Yes, makes sense. Then let's get this merged. |
Description
Add dark ownCloud logo
Related Issue
Motivation and Context
Screenshots (if appropriate):
Types of changes