Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dark ownCloud logo #8522

Merged
merged 2 commits into from
Mar 2, 2023
Merged

add dark ownCloud logo #8522

merged 2 commits into from
Mar 2, 2023

Conversation

hurradieweltgehtunter
Copy link
Contributor

@hurradieweltgehtunter hurradieweltgehtunter commented Mar 2, 2023

Description

Add dark ownCloud logo

Related Issue

Motivation and Context

Screenshots (if appropriate):

grafik

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change the file reference for the logo in the common section of the default theme to this file? That way the other clients can pick up this new variant of the logo.

here:
https://github.com/owncloud/web/blob/master/packages/web-runtime/themes/owncloud/theme.json#L5

@hurradieweltgehtunter
Copy link
Contributor Author

Could you please change the file reference for the logo in the common section of the default theme to this file? That way the other clients can pick up this new variant of the logo.

here: https://github.com/owncloud/web/blob/master/packages/web-runtime/themes/owncloud/theme.json#L5

The purpose of this PR is to just provide a dark logo, so one could use it if needed. I'm not sure if we should change the default one.
Let's wait for #8425 if this idea is even suitable.

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kulmann
Copy link
Contributor

kulmann commented Mar 2, 2023

The purpose of this PR is to just provide a dark logo, so one could use it if needed. I'm not sure if we should change the default one. Let's wait for #8425 if this idea is even suitable.

Yes, makes sense. Then let's get this merged.

@kulmann kulmann merged commit 81696e5 into master Mar 2, 2023
@delete-merged-branch delete-merged-branch bot deleted the add-dark-logo branch March 2, 2023 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Design] Make the instance logo work on light and dark backgrounds
2 participants