Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce open url files with system actions #10004

Closed
wants to merge 1 commit into from
Closed

Enforce open url files with system actions #10004

wants to merge 1 commit into from

Conversation

AlexAndBear
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Nov 18, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

AlexAndBear
AlexAndBear commented Nov 18, 2023
View reviewed changes
packages/web-pkg/src/composables/actions/files/useFileActions.ts
@@ -276,6 +276,11 @@ export const useFileActions = ({ store }: { store?: Store<any> } = {}) => {
return []
}

// enforce open url files with system actions
if (options.resources[0].extension === 'url') {
Copy link
Contributor Author

@AlexAndBear AlexAndBear Nov 18, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.url files will have 'application/ocet-stream' as mimetype. Which is assigned to Collabora and OnlyOffice, therefore url files will be opened with respective editors.

We might fix it in the frontend with this code or need to ask OCIS to return another mime-type like
text/url

Backend solution would be here:
cs3org/reva#4344

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AlexAndBear
Copy link
Contributor Author

Alternative backend solution: cs3org/reva#4344

dschmidt
dschmidt approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer the backend solution, but if they can't/don't want to do it, I'm fine with this as welll

@AlexAndBear
Copy link
Contributor Author

I would prefer the backend solution, but if they can't/don't want to do it, I'm fine with this as welll

Same here. If ocis/reva PRs are merged, I'll close this.

@AlexAndBear
Copy link
Contributor Author

Closed in favor of cs3org/reva#4344

@kulmann kulmann deleted the issues/9968 branch September 5, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschmidt dschmidt dschmidt approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clicking a .url file in the file list opens in external app
2 participants
@AlexAndBear @dschmidt