Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shares search filter #10033

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Shares search filter #10033

merged 2 commits into from
Nov 23, 2023

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Nov 22, 2023 •
edited
Loading

Description

Adds a text search filter to the 'Shared with me'-page and aligns the other search inputs to the right.

Related Issue

Screenshot

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Nov 22, 2023
@JammingBen JammingBen force-pushed the shares-search-filter branch 5 times, most recently from 2e2c04b to 484bf61 Compare November 22, 2023 09:44
@JammingBen JammingBen marked this pull request as ready for review November 22, 2023 10:39
AlexAndBear
AlexAndBear requested changes Nov 23, 2023
View reviewed changes
Copy link
Contributor

@AlexAndBear AlexAndBear left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately you missed the trashbin adjustments :(

@JammingBen
Copy link
Contributor Author

Unfortunately you missed the trashbin adjustments :(

The acceptance criteria are missing it :P But yes, you're totally right

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

87.5% 87.5% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen merged commit cd16c43 into master Nov 23, 2023
2 checks passed
@kulmann kulmann deleted the shares-search-filter branch September 5, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@dschmidt dschmidt dschmidt approved these changes

@lookacat lookacat Awaiting requested review from lookacat

@kulmann kulmann Awaiting requested review from kulmann

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] Add search filter to shared with me (and align position across views)
3 participants
@JammingBen @dschmidt @AlexAndBear