chore: remove homeFolder option #10122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
dschmidt
force-pushed
the
remove-home-folder-option
branch
from
ec0dd4a to
bdac992
Compare
JammingBen
force-pushed
the
remove-home-folder-option
branch
from
bdac992 to
1486f41
Compare
Open
JammingBen
force-pushed
the
remove-home-folder-option
branch
4 times, most recently
from
f843c58 to
74db069
Compare
kulmann
suggested changes
Jan 5, 2024
| import { createFileRouteOptions } from '@ownclouders/web-pkg' | ||
| import { createLocationSpaces } from '@ownclouders/web-pkg' | ||
|
|
||
| // 'personal/home' is used as personal drive alias from static contexts | ||
| // (i.e. places where we can't load the actual personal space) | ||
| const fakePersonalDriveAlias = 'personal/home' |
There was a problem hiding this comment.
This is still needed for the nightwatch acceptance tests, see
- and
As soon as we remove the nightwatch acceptance tests from this repo, those two routes and the fakePersonalDriveAlias handling here can be removed. personal/home has nothing to do with the CERN homeFolder feature.
| if (!props.appendHomeFolder) { | ||
| return '' | ||
| } | ||
| const item = props.driveAliasAndItem.startsWith(fakePersonalDriveAlias) |
There was a problem hiding this comment.
This part is still needed. For reasoning see other comment on the variable declaration.
JammingBen
force-pushed
the
remove-home-folder-option
branch
from
74db069 to
493c884
Compare
|
ownclouders
pushed a commit
that referenced
this pull request
Jan 8, 2024
chore: remove homeFolder option
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes
homeFolderoption.Related Issue
Motivation and Context
CERN is implementing space apis now. If they want to show a full path, we need to handle it in breadcrumbs but not like this.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: