refactor: space readme modal usage #10198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kulmann
approved these changes
Dec 18, 2023
Removes the password logic from the modal implementation and uses a custom component instead.
Before, the state of the space readme modal was handled by the outside where it was being used. Refactors the modal usage so that the modal state handling is done via the edit space readme action instead, meaning the consuming party doesn't need to care about it anymore.
JammingBen
force-pushed
the
refactor-space-readme-modal
branch
from
27f0543 to
ae367fa
Compare
|
dschmidt
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before, the state of the space readme modal was handled by the outside where it was being used. Refactors the modal usage so that the modal state handling is done via the edit space readme action instead, meaning the consuming party doesn't need to care about it anymore.
Related Issue
Types of changes