Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: minimize share sdk usage #10614

Merged
merged 4 commits into from
Mar 19, 2024
Merged

refactor: minimize share sdk usage #10614

merged 4 commits into from
Mar 19, 2024

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Mar 14, 2024 •
edited
Loading

Description

  • get share from graph instead of ocs when resolving private links
  • use sharing NG for editing sync status
  • remove sdk usage for setting hidden share state
  • remove sdk usage for tokeninfo

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen self-assigned this Mar 14, 2024
@update-docs Update Docs
Copy link

update-docs bot commented Mar 14, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen JammingBen changed the title refactor: remove multiple share ocs calls refactor: minimize share sdk usage Mar 14, 2024
@JammingBen JammingBen force-pushed the remove-ocs-call-private-link-resolving branch 2 times, most recently from 9d0e566 to ae78a32 Compare March 15, 2024 06:25
@JammingBen JammingBen force-pushed the remove-ocs-call-private-link-resolving branch from ae78a32 to b0e674a Compare March 15, 2024 07:41
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
35.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@JammingBen JammingBen marked this pull request as ready for review March 15, 2024 08:12
kulmann
kulmann approved these changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@JammingBen JammingBen merged commit 241d7da into master Mar 19, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the remove-ocs-call-private-link-resolving branch March 19, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

@dschmidt dschmidt Awaiting requested review from dschmidt

@AlexAndBear AlexAndBear Awaiting requested review from AlexAndBear

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JammingBen @kulmann