fix: capitalization of banned password error message #10685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
kulmann
reviewed
Apr 2, 2024
packages/web-app-files/src/components/Modals/SetLinkPasswordModal.vue
Outdated
Show resolved
Hide resolved
JammingBen
force-pushed
the
fix-banned-password-error-capitalization
branch
from
22eac07 to
bea6a2f
Compare
JammingBen
force-pushed
the
fix-banned-password-error-capitalization
branch
from
bea6a2f to
cda6b9a
Compare
|
delete-merged-branch
bot
deleted the
fix-banned-password-error-capitalization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Regression of #10433.
With sharing NG, the server doesn't capitalize the first letter of the banned password error message (or error messages in general). Therefore we need to capitalize it manually until we have a better solution (error codes? translations via server?).
Related Issue
Types of changes