fix: missing password modal on link type change #10690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Fixes an issue where the password modal was missing when link passwords are enforced and the type of a link changes from internal to anything other.
JammingBen
force-pushed
the
fix-missing-password-modal
branch
from
6557afa to
3f160e9
Compare
|
kulmann
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where the password modal was missing when link passwords are enforced and the type of a link changes from internal (or viewer for admins) to anything other.
This was a bit tricky because we first need to add the password to a link and then update its role. The most elegant way of doing this (at least what I found) was by adding a callback function to the password modal component.
Regression of #10433.
Related Issue
Types of changes