Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix new notifications broken while notification center is open #10760

Merged
merged 16 commits into from
Apr 11, 2024
Merged

Fix new notifications broken while notification center is open #10760

merged 16 commits into from
Apr 11, 2024

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Apr 10, 2024 •
edited
Loading

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

@update-docs Update Docs
Copy link

update-docs bot commented Apr 10, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@AlexAndBear AlexAndBear requested a review from JammingBen April 10, 2024 09:50
@AlexAndBear AlexAndBear marked this pull request as ready for review April 10, 2024 10:44
@AlexAndBear AlexAndBear requested a review from dschmidt April 10, 2024 14:20
dschmidt
dschmidt approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@AlexAndBear AlexAndBear enabled auto-merge (squash) April 11, 2024 08:41
@AlexAndBear AlexAndBear disabled auto-merge April 11, 2024 08:54
@AlexAndBear AlexAndBear enabled auto-merge (squash) April 11, 2024 12:20
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
97.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@AlexAndBear AlexAndBear merged commit cd03d40 into master Apr 11, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the issues/10602 branch April 11, 2024 13:00
@micbar micbar mentioned this pull request Jun 19, 2024
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschmidt dschmidt dschmidt approved these changes

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incoming notifications don't render properly when notifications open
3 participants
@AlexAndBear @dschmidt @JammingBen