-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhancement: configurable share role icons #10801
Conversation
ece3c8c
to
f78fde7
Compare
f78fde7
to
1944ec3
Compare
Co-authored-by: Jannik Stehle <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Docs still need the naming adjustment, rest LGTM 👍
Co-authored-by: Jannik Stehle <[email protected]>
Co-authored-by: Jannik Stehle <[email protected]>
Quality Gate passedIssues Measures |
* enhancement: configurable share role icons Co-authored-by: Jannik Stehle <[email protected]>
This PR has caused a schema validation error on the default theme: ZodError: [
{
"code": "invalid_type",
"expected": "object",
"received": "undefined",
"path": [
"common",
"shareRoles"
],
"message": "Required"
}
] |
Did you run |
thank you 😆 🤦🏻♂️ |
Description
Introduce themeable sharing role icons which are used in the sidebar sharing dialog.
Related Issue
Motivation and Context
give the individual user the ability to customize the look of the sharing role dropdown
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes