Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: configurable share role icons #10801

Merged
merged 5 commits into from
Apr 19, 2024
Merged

enhancement: configurable share role icons #10801

merged 5 commits into from
Apr 19, 2024

Conversation

fschade
Copy link
Contributor

@fschade fschade commented Apr 17, 2024

Description

Introduce themeable sharing role icons which are used in the sidebar sharing dialog.

Related Issue

Motivation and Context

give the individual user the ability to customize the look of the sharing role dropdown

How Has This Been Tested?

  • missing unit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@fschade fschade force-pushed the theme-role-icon branch 2 times, most recently from ece3c8c to f78fde7 Compare April 17, 2024 13:47
@fschade fschade marked this pull request as ready for review April 18, 2024 13:34
@fschade fschade requested a review from JammingBen April 18, 2024 13:47
@fschade fschade requested a review from JammingBen April 19, 2024 06:34
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs still need the naming adjustment, rest LGTM 👍

docs/theming/_index.md Outdated Show resolved Hide resolved
docs/theming/_index.md Outdated Show resolved Hide resolved
fschade and others added 2 commits April 19, 2024 11:01
Co-authored-by: Jannik Stehle <[email protected]>
Co-authored-by: Jannik Stehle <[email protected]>
Copy link

@JammingBen JammingBen merged commit 54bc36f into master Apr 19, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the theme-role-icon branch April 19, 2024 12:42
ownclouders pushed a commit that referenced this pull request Apr 19, 2024
* enhancement: configurable share role icons

Co-authored-by: Jannik Stehle <[email protected]>
@kulmann
Copy link
Contributor

kulmann commented Apr 22, 2024

This PR has caused a schema validation error on the default theme:

ZodError: [
  {
    "code": "invalid_type",
    "expected": "object",
    "received": "undefined",
    "path": [
      "common",
      "shareRoles"
    ],
    "message": "Required"
  }
]

@JammingBen
Copy link
Contributor

This PR has caused a schema validation error on the default theme:

Did you run pnpm build? I can't reproduce it 🤔

@kulmann
Copy link
Contributor

kulmann commented Apr 22, 2024

This PR has caused a schema validation error on the default theme:

Did you run pnpm build? I can't reproduce it 🤔

thank you 😆 🤦🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Sharing NG] Remove share role icon map
3 participants