Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local docker compose setup not working with app-providers #10885

Merged
merged 1 commit into from
May 7, 2024

Conversation

saw-jan
Copy link
Member

@saw-jan saw-jan commented May 7, 2024

Description

local docker-compose setup was not working with app-providers due to security policies. This PR has a fix for that

Similar to: #10856, owncloud/ocis#9025 due to owncloud/ocis#8777

Related Issue

How Has This Been Tested?

  • 💻

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@saw-jan saw-jan added the QA:team label May 7, 2024
@saw-jan saw-jan self-assigned this May 7, 2024
Copy link

update-docs bot commented May 7, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome. thank you Sajan

need only rebase to make CI happy

@saw-jan saw-jan force-pushed the tests/fix-local-docker-compose branch from c24a883 to be6aec3 Compare May 7, 2024 13:33
@saw-jan
Copy link
Member Author

saw-jan commented May 7, 2024

awesome. thank you Sajan

need only rebase to make CI happy

I tried to find the reported issue in web but it was in ocis. Thanks Viktor 👍

@saw-jan saw-jan merged commit 1c97278 into master May 7, 2024
2 checks passed
@delete-merged-branch delete-merged-branch bot deleted the tests/fix-local-docker-compose branch May 7, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] wopi in web development setup is broken because of CSP
3 participants