You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enhances colors in the default theme so they have at least a 4.5:1 contrast ratio because of a11y reasons.
Note that checking out this PR will not change the colors since those are only being used as fallback if no theme was provided by oCIS. owncloud/ocis#9752 is for the actual theme change in oCIS.
Notable changes:
reduced the opacity in a few spots, e.g. the file extensions in the "New"-menu, a cut resource
reduced the brightness of the secondary background color in dark mode
redefined colors for the danger button in dark mode (see "Empty trash bin"-button)
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.
JammingBen
changed the title
fix: color contrasts
fix: color contrasts in default theme
Aug 7, 2024
JammingBen
changed the title
fix: color contrasts in default theme
feeat: color contrasts in default theme
Aug 7, 2024
JammingBen
changed the title
feeat: color contrasts in default theme
feat: color contrasts in default theme
Aug 7, 2024
is the contrast of the danger button in dark mode & validation error text color supposed to be fixed? (currently, contrasts are not high enough)
Yes, as described above, checking out this PR will not display the changes. It's just the fallback theme if oCIS fails to deliver a theme. So you either need to run oCIS with owncloud/ocis#9752, or mount the theme in the docker container via a volume: - ./packages/web-runtime/themes/owncloud/theme.json:/themes/owncloud/theme.json
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JammingBen
changed the title
Description
Enhances colors in the default theme so they have at least a 4.5:1 contrast ratio because of a11y reasons.
Note that checking out this PR will not change the colors since those are only being used as fallback if no theme was provided by oCIS. owncloud/ocis#9752 is for the actual theme change in oCIS.
Notable changes:
Related Issue
Types of changes