Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust link type descriptions and remove "Uploader" type #11661

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

JammingBen
Copy link
Contributor

Description

As per title.

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@JammingBen JammingBen requested a review from tbsbdr September 26, 2024 08:45
@JammingBen JammingBen self-assigned this Sep 26, 2024
Copy link

update-docs bot commented Sep 26, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen
Copy link
Contributor Author

@tbsbdr Some annotations to #11381 (comment):

Adds edit to Can upload

This would not be correct since editing is currently not allowed for this link role.

Note: In general I'd prefer to remove the Uploader role at all, as it adds little value for the user, but if I understand @micbar correctly this would be expensive due to a migration necessity.

We could give it the same treatment like the internal link, meaning the uploader role wouldn't be available for setting anymore, but existing links with this role still exist and work.

@JammingBen
Copy link
Contributor Author

As discussed with @tbsbdr : We remove the "Uploader" link role while keeping compatibility with existing links with this role.

@JammingBen JammingBen changed the title feat: adjust link type descriptions feat: adjust link type descriptions and remove "Uploader" type Sep 26, 2024
Copy link

@kulmann kulmann merged commit 420cf4a into master Sep 26, 2024
3 checks passed
@kulmann kulmann deleted the feat/link-type-naming branch September 26, 2024 12:18
@micbar micbar mentioned this pull request Oct 1, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change wording of Role Descriptions
2 participants