Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove importer from default apps #11709

Merged
merged 2 commits into from
Oct 7, 2024
Merged

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Oct 2, 2024

BREAKING CHANGE: removes importer from the default web apps. The app is now available via the web-extensions repository. See owncloud/web-extensions#61.

refs #11698

@JammingBen JammingBen self-assigned this Oct 2, 2024
@JammingBen JammingBen force-pushed the feat/remove-importer-app branch from 8459b19 to 83b00d0 Compare October 2, 2024 13:33
BREAKING CHANGE: removes `importer` from the default web apps. The app is now available via the [web-extensions repository](https://github.com/owncloud/web-extensions).
@JammingBen JammingBen force-pushed the feat/remove-importer-app branch from 83b00d0 to 7eefbcd Compare October 7, 2024 05:39
@JammingBen JammingBen marked this pull request as ready for review October 7, 2024 08:37
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we go back to upstream uppy now with companion being removed from the web repo? Or is it still needed in the runtime for the importer app to work correctly?

dev/docker/ocis.web.config.json Outdated Show resolved Hide resolved
@JammingBen
Copy link
Contributor Author

Can't we go back to upstream uppy now with companion being removed from the web repo? Or is it still needed in the runtime for the importer app to work correctly?

It's still needed in the runtime to work unfortunately :(

Copy link

sonarqubecloud bot commented Oct 7, 2024

Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care 🥇

@JammingBen JammingBen merged commit e8fea9d into master Oct 7, 2024
3 checks passed
@JammingBen JammingBen deleted the feat/remove-importer-app branch October 7, 2024 11:16
@micbar micbar mentioned this pull request Oct 21, 2024
18 tasks
@JammingBen JammingBen mentioned this pull request Oct 23, 2024
85 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants