Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrong webdav url in details panel of received shares #11712

Merged
merged 2 commits into from
Oct 4, 2024
Merged

fix: wrong webdav url in details panel of received shares #11712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6b8a88
fix: wrong webdav url in details panel of recieved shares
AlexAndBear Oct 2, 2024
a5f99a9
lint
AlexAndBear Oct 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/bugfix-details-panel-wrong-webdav-url-of-recieved-shares
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Details panel wrong WebDAV URL of received shares

We've fixed a bug where the WebDAV URL in the details panel of received shares was wrong.

https://github.com/owncloud/web/pull/11712
https://github.com/owncloud/web/issues/11704
3 changes: 1 addition & 2 deletions packages/web-pkg/src/components/SideBar/WebDavDetails.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@

<script lang="ts">
import { defineComponent, inject, ref, Ref, computed, unref, PropType } from 'vue'
import { urlJoin } from '@ownclouders/web-client'
import { Resource, SpaceResource } from '@ownclouders/web-client'
import { encodePath } from '../../utils'

Expand All @@ -58,7 +57,7 @@ export default defineComponent({
return encodePath(unref(resource).webDavPath)
})
const webDavUrl = computed(() => {
return urlJoin(props.space?.root?.webDavUrl, unref(resource).path)
return props.space?.getWebDavUrl({ path: unref(resource).path })
})

const copyWebDAVPathToClipboard = () => {
Expand Down