Bugfix: Dropdown menu links not working in Safari #11726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
AlexAndBear
force-pushed
the
issues/11718
branch
from
b8f8e2e to
57f4cae
Compare
AlexAndBear
commented
Oct 6, 2024
| @@ -138,7 +138,8 @@ export default defineComponent({ | |||
| } | |||
|
|
|||
| const onFocusOut = (event: FocusEvent) => { | |||
| const focusLeft = event.relatedTarget && !unref(drop).contains(event.relatedTarget as Node) | |||
| const tippyBox = unref(drop).closest('.tippy-box') | |||
There was a problem hiding this comment.
focusOut event was triggered before the click event and was not bubbling the event up when the hide function was called.
In Chrome/FF the relatedTarget is not set, on Safari it is the tippy box.
Everything is still working fine
|
kulmann
approved these changes
Oct 7, 2024
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: