Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci]enable vips for thumbnails #11862

Merged
merged 2 commits into from
Nov 8, 2024
Merged

[full-ci]enable vips for thumbnails #11862

merged 2 commits into from
Nov 8, 2024

Conversation

ScharfViktor
Copy link
Contributor

@ScharfViktor ScharfViktor commented Nov 6, 2024

After talk with @rhafer we enabled vips for web CI see here owncloud/ocis#10310

we can use it in in webCI and don't use in ocisCi in this way we can check both options

@micbar @kulmann Is that okay?

Copy link

update-docs bot commented Nov 6, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ScharfViktor ScharfViktor marked this pull request as ready for review November 6, 2024 12:05
@kulmann
Copy link
Contributor

kulmann commented Nov 6, 2024

After talk with @rhafer we enabled vips for web CI see here owncloud/ocis#10310

we can use it in in webCI and don't use in ocisCi in this way we can check both options

@micbar @kulmann Is that okay?

Don't like it too much honestly... I'd prefer to switch everything to libvips and have a single e2e thumbnail test with the "old" thumbnailer in a nightly CI run.

@ScharfViktor
Copy link
Contributor Author

Don't like it too much honestly... I'd prefer to switch everything to libvips and have a single e2e thumbnail test with the "old" thumbnailer in a nightly CI run.

we can switch everything to libvips - it's no problem
about how to have a single e2e thumbnail test with the "old" thumbnailer - we need think how

@ScharfViktor
Copy link
Contributor Author

now we run e2e test with libvips by default. in the nightly CI we run tests with the "old" thumbnailer

Copy link

sonarqubecloud bot commented Nov 7, 2024

@kulmann kulmann merged commit 80799b5 into master Nov 8, 2024
3 checks passed
@kulmann kulmann deleted the enableVips branch November 8, 2024 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants