-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable paste button in same folder #12044
Conversation
We've fixed the state of the "paste files" action when copied resources are from the same folder. The button will be disabled in such case and a tooltip with explanation message displayed.
@saw-jan it seems that tests are failing because when trying to click on the breadcrumbs the tooltip of the paste action is overflowing it. Any idea why the paste action would even get hovered when the button is not target of the test step? I.e. the locator is on a different element than the action. Have you seen something like this already? |
Just reviewing it and the test failure. let me have a look at the test. paste button should not be hovered |
packages/web-app-files/src/components/AppBar/CreateAndUpload.vue
Outdated
Show resolved
Hide resolved
packages/web-app-files/src/components/AppBar/CreateAndUpload.vue
Outdated
Show resolved
Hide resolved
Can I push the test fix in this PR? the paste button appears just where the cut button was and the mouse point will be on the same position that's why the tooltip was visible. I can push the fix here |
Yes please. Thanks a lot! |
@saw-jan CI passed, thank you! |
Co-authored-by: Sawjan Gurung <[email protected]>
Co-authored-by: Sawjan Gurung <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Description
We've fixed the state of the "paste files" action when copied resources are from the same folder. The button will be disabled in such case and a tooltip with explanation message displayed.
Related Issue
cut
andpaste
in the same folder #12021Motivation and Context
Prevent overwrite action.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Open tasks: