Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable paste button in same folder #12044

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Conversation

LukasHirt
Copy link
Collaborator

@LukasHirt LukasHirt commented Dec 18, 2024

Description

We've fixed the state of the "paste files" action when copied resources are from the same folder. The button will be disabled in such case and a tooltip with explanation message displayed.

Related Issue

Motivation and Context

Prevent overwrite action.

How Has This Been Tested?

  • test environment: chrome & 🤖
  • test case 1: added unit tests
  • test case 2: try to paste resources in chrome into same folder

Screenshots (if appropriate):

Snímek obrazovky 2024-12-18 v 9 51 41

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open tasks:

  • ...

We've fixed the state of the "paste files" action when copied resources are from the same folder. The button will be disabled in such case and a tooltip with explanation message displayed.
@LukasHirt LukasHirt added the Type:Bug Something isn't working label Dec 18, 2024
@LukasHirt LukasHirt requested review from kobergj and saw-jan December 18, 2024 09:06
@LukasHirt LukasHirt self-assigned this Dec 18, 2024
@LukasHirt
Copy link
Collaborator Author

LukasHirt commented Dec 19, 2024

@saw-jan it seems that tests are failing because when trying to click on the breadcrumbs the tooltip of the paste action is overflowing it. Any idea why the paste action would even get hovered when the button is not target of the test step? I.e. the locator is on a different element than the action. Have you seen something like this already?

image

@saw-jan
Copy link
Member

saw-jan commented Dec 19, 2024

@saw-jan it seems that tests are failing because when trying to click on the breadcrumbs the tooltip of the paste action is overflowing it. Any idea why the paste action would even get hovered when the button is not target of the test step? I.e. the locator is on a different element than the action. Have you seen something like this already?

Just reviewing it and the test failure. let me have a look at the test. paste button should not be hovered

@saw-jan
Copy link
Member

saw-jan commented Dec 19, 2024

@saw-jan it seems that tests are failing because when trying to click on the breadcrumbs the tooltip of the paste action is overflowing it. Any idea why the paste action would even get hovered when the button is not target of the test step? I.e. the locator is on a different element than the action. Have you seen something like this already?

Just reviewing it and the test failure. let me have a look at the test. paste button should not be hovered

Can I push the test fix in this PR? the paste button appears just where the cut button was and the mouse point will be on the same position that's why the tooltip was visible. I can push the fix here

@LukasHirt
Copy link
Collaborator Author

Can I push the test fix in this PR?

Yes please. Thanks a lot!

@LukasHirt
Copy link
Collaborator Author

@saw-jan CI passed, thank you!

@LukasHirt LukasHirt enabled auto-merge December 19, 2024 10:57
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LukasHirt LukasHirt merged commit 92b1b3a into master Dec 19, 2024
4 checks passed
@LukasHirt LukasHirt deleted the fix/paste-in-same-folder branch December 19, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Disable the 'Paste here' when user cut and paste in the same folder
2 participants