Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lower disabled checkbox opacity #12063

Merged
merged 1 commit into from
Dec 31, 2024
Merged

fix: lower disabled checkbox opacity #12063

merged 1 commit into from
Dec 31, 2024

Conversation

LukasHirt
Copy link
Collaborator

Description

We've fixed an issue where disabled checkbox was not clearly distinguishable from enabled ones by lowering it's opacity.

Related Issue

Motivation and Context

Clearly distinguishable checkbox states.

How Has This Been Tested?

  • test environment: chrome
  • test case 1: check disabled and enabled checkboxes

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

@LukasHirt LukasHirt added the Type:Bug Something isn't working label Dec 30, 2024
@LukasHirt LukasHirt requested a review from saw-jan December 30, 2024 10:50
@LukasHirt LukasHirt self-assigned this Dec 30, 2024
@LukasHirt LukasHirt enabled auto-merge December 30, 2024 10:53
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@LukasHirt LukasHirt merged commit eb4f304 into master Dec 31, 2024
4 checks passed
@LukasHirt LukasHirt deleted the fix/disabled-checkbox-opacity branch December 31, 2024 05:34
@2403905 2403905 mentioned this pull request Jan 10, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saw-jan saw-jan saw-jan approved these changes

Assignees

@LukasHirt LukasHirt

Labels
Type:Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notifications settings disabled checkboxes are not visually different
2 participants
@LukasHirt @saw-jan