Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supress redirect error #4759

Merged
merged 1 commit into from
Feb 19, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions changelog/unreleased/surpress-redirect-error
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
Change: Suppress redirect error during authorization

We've suppressed the error appearing in the console which warned about redirect happening after the oidc callback page.
This error is being shown because after the oidc callback has successfully processed the authorization request we are redirecting to the `/` path which immediately does another redirect to the extension set as default one.
In the context of Vue router, this is considered an error even though for us it is a valid use case.
The error is only informative thus no issue is going to surface if we suppress it.
This way we are getting closer to a clean console without errors.

https://github.com/owncloud/web/pull/4759
2 changes: 1 addition & 1 deletion packages/web-runtime/src/store/user.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ const actions = {
context.commit('SET_USER_READY', true)

if (payload.autoRedirect) {
router.push({ path: '/' })
router.push({ path: '/' }).catch(() => {})
}
} else {
context.commit('UPDATE_TOKEN', token)
Expand Down