Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set momentjs locale to current langCode #4826

Merged
merged 1 commit into from
Mar 18, 2021
Merged

set momentjs locale to current langCode #4826

merged 1 commit into from
Mar 18, 2021

Conversation

AlexAndBear
Copy link
Contributor

@AlexAndBear AlexAndBear commented Mar 18, 2021 •
edited
Loading

Description

This PR allows us to render translated moment-js strings e.G for the updated column in the all files list

Related Issue

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@owncloud owncloud deleted a comment from update-docs bot Mar 18, 2021
@AlexAndBear AlexAndBear requested a review from JammingBen March 18, 2021 09:22
kulmann
kulmann approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kulmann kulmann merged commit 152f1af into master Mar 18, 2021
@delete-merged-branch delete-merged-branch bot deleted the moment-js-locale branch March 18, 2021 11:53
@fschade fschade mentioned this pull request Mar 30, 2021
Closed
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JammingBen JammingBen JammingBen approved these changes

@kulmann kulmann kulmann approved these changes

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexAndBear @kulmann @JammingBen